5oappy/feature/delete v2 testing #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hin 'repository/volunteer_unavailability_v2.py' also modified 'tests/functional/test_unavailability.py' to accept new chages to api code.
…_unavailability_delete.py' and unit test for all methods in 'tests/unit/test_repository.py'
|
okay, so its literally just that test case (edit_event) within tests/unit/test_repository not sure whats up. |
TaiHaDev
approved these changes
Apr 17, 2024
emilymclean
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
implemented test criteria for functional testing of delete endpoint, wrote unit test for event repository, modified create/post endpoint in api to check for duplicates instead of overlaps so that events can now overlap but cannot create events that are exactly the same as you can imagine duplicate events will get increasingly annoying for end user. Right now it doesn't care about 'event title' but can add if needed.
Issue ticket number and link
https://fireapp-emergiq-2024.atlassian.net/browse/FE-189?atlOrigin=eyJpIjoiZWQwMjlmY2RmYThkNGM2NzllOGU3NDQyMzRhYmI4MzMiLCJwIjoiaiJ9