Fishchimp/feature/delete unavailability

[fishchimp]

Describe your changes

Slight improvement to the delete unavailability method

considerations:

1. The remove_event method is already a soft delete, which aligns with industry practices
2. The delete method is already quite straightforward
3. Futureproofing ideas include changing the return type of remove_event into an enum to differentiate between a failed "mark event as deleted" and a "cannot find such event to delete".
4. ultimately decided to just add logging for better debugging if any issues were to arise

Issue ticket number and link

Issue FE-187

[emilymclean]

Just to pipe in a suggestion here, but if you're looking to pass failed event deletion up the chain I think throwing an exception would be entirely appropriate. I would subclass exception with "FireAppException", then subclass that with "ClientException" (like a caught validation exception, rather than a genuine bug in our implementation), and then subclass with as many exceptions as you need to represent every failed state. The reason for all the subclasses is so that the consuming endpoint can effectively adjust the scope of what it wants to catch.

Again, this is just a suggestion, feel free to implement how you feel fit.

[TaiHaDev]

Hi @naychithanshwe @BenMMcLean , there was a minor conflict issue between Hafizh's branch and the main branch, so I helped him quickly resolve it. Please approve it so that it can be merged. Thanks!