Automate Uploading to Pypi #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixing #2. |
aaaandrzej
reviewed
Oct 20, 2022
|
I'm not a maintainer here so I'll leave the further review to the repo
maintainers.
…On Thu, Oct 20, 2022 at 4:07 PM Nathan Solis ***@***.***> wrote:
@colderinit <https://github.com/colderinit> requested your review on: #14
<#14> Automate Uploading to
Pypi.
—
Reply to this email directly, view it on GitHub
<#14 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANN6HIZUNU5Y2JCSFD3MZVDWEFG35ANCNFSM6AAAAAARJTZY3I>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Thanks a lot for your work, just wondering why did you choose |
|
By using 'pyproject.toml' and 'poetry' we can retain the project's core metadata in a human-readable yet machine-readable form. |
|
Thanks a lot for your work, the explanation and your followup, really appreciate that 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automate Uploading to PyPI
In this pr, I implemented a Github Action workflow that installs the project's dependencies, builds a release, and then publishes that release to PyPI.
There will be some setup required on your end, @TechWiz-3, but I am happy to walk you through it! My discord is
colderinit#8448.The PyPI account Token is required through Github Actions Secrets.
${{ secrets.PYPI_TOKEN }}