Duda I/O: adding Duda I/O framework tests. #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following patch adds a web service based on Duda I/O framework, at the moment only tests #1 and #6 are implemented. For the next round we will cover Database tests. For more details about the stack and components please refer to: http://duda.io http://monkey-project.com note: this is the second pull request upon requirement to drop the stack from the patch. This PR replaces #905. Signed-off-by: Eduardo Silva <[email protected]>
|
This is a much more sensible PR. There's a few issues with the PR though: When I try to run the test, I get the following error: I suspect it is because you're missing the install file that #900 requries. The frameworks should require no manual setup beyond running the installer command. Are you also including the entire framework? The files in duda/dudac seem extraordinarily long for python files. The framework ideally should be setup in the aforementioned install.sh. Here is some more information on writing one. |
Merged
|
closed with #981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following patch adds a web service based on Duda I/O framework,
at the moment only tests #1 and #6 are implemented. For the next round
we will cover Database tests.
For more details about the stack and components please refer to:
http://duda.io
http://monkey-project.com
note: this is the second pull request upon requirement to drop the stack
from the patch. This PR replaces #905.
Signed-off-by: Eduardo Silva [email protected]