-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java/servlet Caching implementation and updates #2906
Conversation
Travis build for |
@zloster You are right, we can explicitly state that somewhere, however, it is implied by the following rule:
I'll get some wording from the rest of the team and see if we can't get that in the docs. |
Restarted the job |
More updates:
Please, don't merge yet. I want to update the |
@zloster sure, let me know |
@nbrady-techempower Ready.
TODO: different implementation for single query and multiple queries tests. Currently there are warnings due to usage of the same code. |
My notes about the test rules: IMO the test must mandate the usage of non-repeatable random numbers for the IDs. Here I've tried to use the API to get all the cache objects with one operation. But if there are duplicates in the keys list, the resulting list will contain less than the requested number of objects. And currently this is flagged as a warning:
I suspect that most of the cache implementation will have similar semantic.