Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting to JS #76

Closed
wants to merge 1 commit into from
Closed

Converting to JS #76

wants to merge 1 commit into from

Conversation

adam-lynch
Copy link
Contributor

  • Target platforms this affects (Linux, Mac, Mac app store, and or Windows): All
  • What problem does this solve? Resolves Remove CoffeeScript #66
  • Could it break any existing functionality for users? Shouldn't

If anyone else could help test this out, I'd appreciate it.

@enguerran
Copy link

Did you use decaffeinate to convert coffee to JS?

@enguerran
Copy link

Can't we update the node runtime to the last LST version in .travis.yml? 8.12.0 (see https://nodejs.org/en/)

It will help to pass test:

➜  node-auto-launch (js) ✔ npm i
added 237 packages from 444 contributors and audited 379 packages in 5.718s
found 13 low severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details
enguerran@koh-i-noor
➜  node-auto-launch (js) ✗ npm run test

> [email protected] test /home/enguerran/Development/fork/node-auto-launch
> node_modules/mocha/bin/mocha tests/**/*.js --reporter spec

Executable being used for tests: /home/enguerran/Development/fork/node-auto-launch/tests/executables/hv3-linux-x86


  node-auto-launch
    .isEnabled
      ✓ should be disabled
      ✓ should catch errors
    .enable
      ✓ should enable auto launch
      ✓ should catch errors
    .disable
      ✓ should disable auto launch
      ✓ should catch errors


  6 passing (16ms)

enguerran@koh-i-noor
➜  node-auto-launch (js) ✗ node -v
v8.12.0

@Oxalin Oxalin self-assigned this Jan 27, 2024
@Oxalin Oxalin added this to the 6.0.0 milestone Jan 27, 2024
@Oxalin
Copy link
Contributor

Oxalin commented Apr 8, 2024

I'll close this PR since we now have a "decaffeinate" branch with a pending PR that will address the path to JS.

@Oxalin Oxalin closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CoffeeScript
3 participants