Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API consistency #1

Closed
fabiulous opened this issue Sep 8, 2017 · 1 comment
Closed

API consistency #1

fabiulous opened this issue Sep 8, 2017 · 1 comment

Comments

@fabiulous
Copy link

For consistency, I advise to add _ to every attribute.
Currently there is:

{
    "career opportunity": "75.0",
    "company_id": 55,
    "company_name": "Altran Portugal",
    "interview difficult": 45.99999999999999,
    "management quality": "37.5",
    "recognition and reward": "37.5",
    "salary": "37.5",
    "url": "https://pt.teamlyzer.com/companies/altran-portugal",
    "work life balance": "62.5"
}

Some with and some without underscore

@fabiulous
Copy link
Author

Also, some values come as string and others as float

ghost pushed a commit that referenced this issue Sep 15, 2017
- Now all output values are strings #1 (comment)
- URL of detailed_rating now is detailed-rating
- Now all dict keys have underscore #1 (comment)
- interview difficult now interview_difficulty #2 (comment)
- Percentage value error now corrected
@ghost ghost closed this as completed Sep 17, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant