Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] #534 - 방 생성 뷰 노티 추가, 삭제하는 시점 수정 #535

Merged
merged 1 commit into from
Apr 16, 2022
Merged

[Fix] #534 - 방 생성 뷰 노티 추가, 삭제하는 시점 수정 #535

merged 1 commit into from
Apr 16, 2022

Conversation

yangsubinn
Copy link
Member

🔥Pull requests

⛳️ 작업한 브랜치

👷 작업한 내용

방 생성 뷰 노티 추가, 삭제하는 시점 수정

🚨참고 사항

willAppear과 didDisappear 에 각각 추가하고 삭제하도록 했습니당

📸 스크린샷

기능 스크린샷
GIF

📟 관련 이슈

@yangsubinn yangsubinn added Fix 오류 해결, 코드 수정 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아 labels Apr 16, 2022
@yangsubinn yangsubinn requested review from hyun99999 and L-j-h-c April 16, 2022 04:10
@yangsubinn yangsubinn self-assigned this Apr 16, 2022
hyun99999
hyun99999 approved these changes Apr 16, 2022
View reviewed changes
Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하... 그렇군요 이외에도 생각해봤는데 입력해두고 다시 돌아가는 플로우는 여기뿐인거 같아요!
노티 담당..일찐..이시네

L-j-h-c
L-j-h-c approved these changes Apr 16, 2022
View reviewed changes
Copy link
Member

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다😆😆

@yangsubinn yangsubinn merged commit 8c5ce6d into TeamSparker:develop Apr 16, 2022
@hyun99999 hyun99999 mentioned this pull request Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-j-h-c L-j-h-c L-j-h-c approved these changes

@hyun99999 hyun99999 hyun99999 approved these changes

Assignees

@yangsubinn yangsubinn

Labels
Fix 오류 해결, 코드 수정 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] 방생성뷰 다시 돌아왔을때 숫자 카운트 안변하는 문제
3 participants
@yangsubinn @hyun99999 @L-j-h-c