Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] #484 - 습관방 이용가이드 닫기 버튼 분기처리 #486

Merged
merged 2 commits into from
Apr 5, 2022
Merged

[Fix] #484 - 습관방 이용가이드 닫기 버튼 분기처리 #486

merged 2 commits into from
Apr 5, 2022

Conversation

yangsubinn
Copy link
Member

🔥Pull requests

⛳️ 작업한 브랜치

👷 작업한 내용

습관방 이용가이드 닫기 버튼 분기처리

  • fromMore이라는 변수를 사용했습니다.
  • 습관방에서 더보기로 들어갈때만 true로 설정하여 이 전의 스크롤 이벤트들을 !fromMore일 경우에만 가능하도록 막았습니다.

🚨참고 사항

📸 스크린샷

기능 스크린샷
GIF

📟 관련 이슈

@yangsubinn yangsubinn added Fix 오류 해결, 코드 수정 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아 labels Apr 5, 2022
@yangsubinn yangsubinn requested review from hyun99999 and L-j-h-c April 5, 2022 08:55
@yangsubinn yangsubinn self-assigned this Apr 5, 2022
hyun99999
hyun99999 approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false 로 초기화하고 필요에 따라서 값을 바꾸는 흐름이 좋은듯해요! 고생하셨어요!

L-j-h-c
L-j-h-c approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@yangsubinn yangsubinn merged commit 464127b into TeamSparker:develop Apr 5, 2022
@hyun99999 hyun99999 mentioned this pull request Apr 9, 2022
Merged
@yangsubinn yangsubinn deleted the feature/#484 branch April 13, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-j-h-c L-j-h-c L-j-h-c approved these changes

@hyun99999 hyun99999 hyun99999 approved these changes

Assignees

@yangsubinn yangsubinn

Labels
Fix 오류 해결, 코드 수정 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] 습관방 이용가이드 닫기 버튼 분기처리
3 participants
@yangsubinn @hyun99999 @L-j-h-c