Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] #384 - 마이페이지 알림 뷰 구현 #436

Merged
merged 12 commits into from
Mar 29, 2022

Conversation

hyun99999
Copy link
Member

🔥Pull requests

⛳️ 작업한 브랜치

👷 작업한 내용

  • 마이페이지 알림뷰 구현

🚨참고 사항

  • 셀간격을 임의로 잡다보니 switch 를 centerY 에 잡을 수 없었고 titleLabel 을 기준으로 잡았습니당

스크린샷 2022-03-28 오후 4 25 22

- 셀의 영역은 다음과 같습니당

스크린샷 2022-03-28 오후 4 18 39

📸 스크린샷

기능 스크린샷
알림뷰

📟 관련 이슈

@hyun99999 hyun99999 added Feat 새로운 기능 구현 👼타락pOwEr천사현규 크로아서버 환영요 labels Mar 28, 2022
@hyun99999 hyun99999 requested review from L-j-h-c and yangsubinn March 28, 2022 09:27
@hyun99999 hyun99999 self-assigned this Mar 28, 2022
Copy link
Member

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이쁜 코드 잘 봤습니다!!


private let titleLabel = UILabel()
private let subtitleLabel = UILabel()
private let notificationSwitch = UISwitch()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와울

headerTitleLabel.text = "스파커 활동"
case .remind:
headerTitleLabel.text = "리마인드"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🌷

Comment on lines +113 to +128
switch section {
case .information:
rowOfSection = [.roomStart]

return rowOfSection.count
case .sparkerActivity:

rowOfSection = [.spark, .consider, .certification]

return rowOfSection.count
case .remind:

rowOfSection = [.remind]

return rowOfSection.count
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쇽샥해놨다가...나중에...써먹어야징

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나도...

Copy link
Member

@yangsubinn yangsubinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확실히.. 테이블뷰는 컬렉션뷰에 비해 많이 안써봐서 먼가.. 새롭네요.. 💭🙇‍♀️

Comment on lines +8 to +9
import UIKit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import가 슬쩍 없서라

Copy link
Member Author

@hyun99999 hyun99999 Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아이쿠야 매섭다매서워 🙇🏻‍♂️

Comment on lines +113 to +128
switch section {
case .information:
rowOfSection = [.roomStart]

return rowOfSection.count
case .sparkerActivity:

rowOfSection = [.spark, .consider, .certification]

return rowOfSection.count
case .remind:

rowOfSection = [.remind]

return rowOfSection.count
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나도...

…arker#384`

# Conflicts:
#	Spark-iOS/Spark-iOS/Resource/Constants/Storyboard.swift
#	Spark-iOS/Spark-iOS/Resource/Constants/ViewController.swift
@hyun99999 hyun99999 merged commit 99ecab4 into TeamSparker:develop Mar 29, 2022
@hyun99999 hyun99999 deleted the feature/#384 branch March 29, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 👼타락pOwEr천사현규 크로아서버 환영요
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 마이페이지 알림 뷰 구현
3 participants