Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] #420 - 홈 티켓 흰줄 제거 및 프로필 모서리 수정 #421

Merged
merged 1 commit into from
Mar 22, 2022
Merged

[Fix] #420 - 홈 티켓 흰줄 제거 및 프로필 모서리 수정 #421

merged 1 commit into from
Mar 22, 2022

Conversation

hyun99999
Copy link
Member

@hyun99999 hyun99999 commented Mar 21, 2022 •
edited
Loading

🔥Pull requests

⛳️ 작업한 브랜치

👷 작업한 내용

  • se2 / 13 / 13 Pro / 13 Pro Max
  • 위의 기기에서 모두 확인했고, 문제 없음을 확인했습니당.
  • 왼쪽 flake image 는 스보에서 비율로 잡혀있고, 우측의 ticket image 는 나머지를 채우고있는데요.
  • 셀의 크기도 비율로 잡고있어서 fill 로 해도 결국 ticket image 도 비율로 잡힌다고 판단하고 수정했습니다.
  • 프로필 크기가 28*28 이었어서 14로 corner radius 로 변경했습니다.

📟 관련 이슈

@hyun99999 hyun99999 added Fix 오류 해결, 코드 수정 👼타락pOwEr천사현규 크로아서버 환영요 labels Mar 21, 2022
@hyun99999 hyun99999 requested review from L-j-h-c and yangsubinn March 21, 2022 10:42
@hyun99999 hyun99999 self-assigned this Mar 21, 2022
yangsubinn
yangsubinn approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@yangsubinn yangsubinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♀️💐

L-j-h-c
L-j-h-c approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이걸어케아셨대....😎😎

@hyun99999 hyun99999 merged commit 3d0fccb into TeamSparker:develop Mar 22, 2022
@hyun99999 hyun99999 deleted the feature/#420 branch March 22, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangsubinn yangsubinn yangsubinn approved these changes

@L-j-h-c L-j-h-c L-j-h-c approved these changes

Assignees

@hyun99999 hyun99999

Labels
Fix 오류 해결, 코드 수정 👼타락pOwEr천사현규 크로아서버 환영요
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] 홈 티켓 흰줄 제거 및 프로필 모서리 수정
3 participants
@hyun99999 @L-j-h-c @yangsubinn