[Feat] #36 - 인증사진 모아보기 뷰 레이아웃 구현 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
인증사진 모아보기 뷰 파일 세팅
인증사진 모아보기 스토리보드 추가
MoreStorageCV 뼈대 구현
StorageVC 컬렉션 셀 선택시 화면전환 기능 구현
bgLineGrid Asset 추가
MoreStorageCVC 레이아웃 구현
프로젝트 최신화
MoreStorageCV 레이아웃 완성
CarouselCVC 레이아웃 수정
StorageCVCs 레이아웃 디자인
gradient 함수 UIView 익스텐션으로 이동
storageCVC들 케이스 처리
코드리뷰 및 TODO 주석 추가
…to feature/TeamSparker#36 [Merge] TeamSparker#36 - 프로젝트 최신화 프로젝트 최신화했습니다
hyun99999
approved these changes
Jan 13, 2022
Comment on lines
+19
to
+23
| func setLayout() { | ||
| dDayLabel.font = .p2Subtitle2Eng | ||
| dDayLabel.textColor = .sparkGray | ||
| dDayLabel.text = "D-day" | ||
| } |
There was a problem hiding this comment.
서버통신하고 뷰컨에서 셀을 세팅해줄때 initCell() 사용하면 좋겠네요~
Comment on lines
+42
to
+43
| let xibCollectionViewName = UINib(nibName: "MoreStorageCVC", bundle: nil) | ||
| storageMoreCV.register(xibCollectionViewName, forCellWithReuseIdentifier: "MoreStorageCVC") |
Comment on lines
+82
to
+89
| print(totalCellWidth) | ||
| print(totalSpacingWidth) | ||
| let leftInset = totalSpacingWidth/2 | ||
| print(leftInset) | ||
| let rightInset = leftInset | ||
| let A = UIEdgeInsets(top: 0, left: leftInset, bottom: 0, right: rightInset) | ||
| print(A) | ||
| return A |
conflict 해결
|
담 풀리퀘때 const 반영해놓겠슴당! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📌 추후 예정
📸 스크린샷