[Feat] #402 - 피드 게시물 하나인 경우 footer 로딩 막기 #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyun99999
approved these changes
Mar 19, 2022
Comment on lines
296
to
298
| if self.feedList.count >= self.feedCountSize { | ||
| self.isFirstScroll = false | ||
| } |
There was a problem hiding this comment.
feedCountSize 보다 같거나 작으면 무조건 첫번째 스크롤이잖아여? must....? 를 변수에 붙여도 좋을거 같구여
의도에 맞춘다면 조건문이 > 이렇게 되야할거같아요!
Merge branch 'develop' of https://github.com/TeamSparker/Spark-iOS into feature/TeamSparker#402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥Pull requests
⛳️ 작업한 브랜치
👷 작업한 내용
피드 게시물 하나인 경우 footer 로딩 막기
🚨참고 사항
새로운 변수 안만들고 하려고 countSize도 써보고 했는데, 쉽지 않아서
isFirstScroll이라는 변수를 만들어서 사용했습니다📸 스크린샷
📟 관련 이슈