Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #72 - 뷰 디테일 수정 #124

Merged
merged 12 commits into from
Jan 19, 2022
Merged

[Feat] #72 - 뷰 디테일 수정 #124

merged 12 commits into from
Jan 19, 2022

Conversation

yangsubinn
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 타이머 단위 수정
  • 타이머 분기처리
  • 사진 업로드 하단 버튼 플로우, 멘트 변경
  • 피드뷰 한 번에 7-10개씩
  • 뷰 멘트 수정(ProfileSetting, CreateRoom, CreateAuth, AuthTimer, ResetPopup, AuthUpload, GoalWriting, Waiting, PhotoAuthView, TimerAuthView)

📌 참고 사항

📸 스크린샷

기능 스크린샷
타이머 수정 ezgif com-gif-maker (40)
사진업로드 하단 플로우 수정 ezgif com-gif-maker (41)

📮 관련 이슈

@yangsubinn yangsubinn added Fix 오류 해결, 코드 수정 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아 🚨review_required🚨 긴급! 빠르게 확인해야할 사항 labels Jan 19, 2022
@yangsubinn yangsubinn self-assigned this Jan 19, 2022
@yangsubinn yangsubinn changed the title Feature/#72 [Feat] #72 - 뷰 디테일 수정 Jan 19, 2022
hyun99999
hyun99999 approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

멘트 보시느라 고생하셨습니당!

@yangsubinn yangsubinn merged commit ede4264 into TeamSparker:develop Jan 19, 2022
@yangsubinn yangsubinn deleted the feature/#72 branch January 27, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyun99999 hyun99999 hyun99999 approved these changes

@L-j-h-c L-j-h-c Awaiting requested review from L-j-h-c

Assignees

@yangsubinn yangsubinn

Labels
Fix 오류 해결, 코드 수정 🚨review_required🚨 긴급! 빠르게 확인해야할 사항 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] 뷰 디테일 수정
2 participants
@yangsubinn @hyun99999