[Feat] #97 - 스파크 보내기 뷰 구현 및 사진인증 서버 연결 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
사진 인증 서버연결 초기 세팅
# Conflicts: # Spark-iOS/Spark-iOS.xcodeproj/project.pbxproj # Spark-iOS/Spark-iOS/Source/NetworkServices/Room/RoomService.swift
인증사진 서버 연결 완료
스파크 보내기 뷰 UI및 레이아웃
스파크 보내기 뷰 버튼 선택기능 구현
코드로 대기방 확인 화면전환 방식 변경 및 사진인증 코드 수정
hyun99999
reviewed
Jan 18, 2022
Comment on lines
48
to
50
| case .enterRoom, .authUpload: | ||
| return .post | ||
| } |
| @@ -21,6 +21,7 @@ class AuthUploadVC: UIViewController { | |||
| // MARK: - Properties | |||
|
|
|||
| var vcType: VCCase = .albumTimer | |||
| var roomID: Int = -1 | |||
Comment on lines
338
to
347
| case .requestErr(let message): | ||
| print(message) | ||
| print("requestErr") | ||
| case .pathErr: | ||
| print("pathErr") | ||
| case .serverErr: | ||
| print("serverErr") | ||
| case .networkFail: | ||
| print("networkFail") | ||
| } |
There was a problem hiding this comment.
print 문 없애주시공 각 에러 메시지 앞에 authUploadWithAPI 붙여주세여~ 헷갈립니당
| sender.titleLabel?.backgroundColor = .sparkMostLightPinkred | ||
| sender.layer.borderColor = UIColor.sparkDarkPinkred.cgColor | ||
| selectedMessage = sender.titleLabel?.text ?? "" | ||
| print(selectedMessage) |
Comment on lines
119
to
121
| class MyButton: UIButton { | ||
| public var statusCV: Int? | ||
| public var statusCV: Int = -1 | ||
| } |
| class SendSparkVC: UIViewController { | ||
|
|
||
| // MARK: Properties | ||
| var selectedIndex: Int = -1 |
| switch status { | ||
| case 1: | ||
| [firstButton, secondButton, thirdButton, fourthButton].forEach { | ||
| if $0.statusCV != 1 { |
코드리뷰 반영
# Conflicts: # Spark-iOS/Spark-iOS.xcodeproj/project.pbxproj # Spark-iOS/Spark-iOS/Source/SceneDelegate.swift
hyun99999
approved these changes
Jan 18, 2022
| switch response { | ||
| case .success(let data): | ||
| if let authUpload = data as? AuthUpload { | ||
| print(authUpload) |
| self.uploadButton.isEnabled = true | ||
| } | ||
| case .requestErr(let message): | ||
| print(message) |
There was a problem hiding this comment.
요거 requestErr 다음에 출력하게 하면 더 잘보일거에여
사진 데이터 png형식으로 변경
# Conflicts: # Spark-iOS/Spark-iOS.xcodeproj/project.pbxproj # Spark-iOS/Spark-iOS/Source/NetworkServices/Room/RoomService.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📌 참고 사항
📮 관련 이슈