Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] SendSparkButton 이니셜라이저를 활용한 초기화로 리펙토링 #571

Closed
1 task
hyun99999 opened this issue Apr 27, 2022 · 0 comments · Fixed by #604
Closed
1 task

[Refactor] SendSparkButton 이니셜라이저를 활용한 초기화로 리펙토링 #571

hyun99999 opened this issue Apr 27, 2022 · 0 comments · Fixed by #604
Assignees
@hyun99999
Labels
👼타락pOwEr천사현규 크로아서버 환영요 👷Refactor👷‍♂️ 동작변화없이 내부구조 변경

Comments

@hyun99999
Copy link
Member

hyun99999 commented Apr 27, 2022 •
edited
Loading

🛠 Issue

  • 현재 setUI() 함수를 통해서 변수를 설정해주고 있는데 이니셜라이저를 활용해서 초기화를 진행하도록 하겠습니다.

📝 To-do

  • SendSparkButton init 리펙토링
@hyun99999 hyun99999 added 👷Refactor👷‍♂️ 동작변화없이 내부구조 변경 👼타락pOwEr천사현규 크로아서버 환영요 labels Apr 27, 2022
@hyun99999 hyun99999 self-assigned this Apr 27, 2022
hyun99999 added a commit to hyun99999/Spark-iOS that referenced this issue May 9, 2022
@hyun99999
[Refactor] TeamSparker#571 - SendSparkButton 이니셜라이저를 활용한 초기화로 리펙토링
a45dcc3 
- 불필요한 오버라이드하던 생성자 삭제.
- UI 가 변경되면서 사용하지 않던 isSelected 삭제.
- didset property observer 를 통해서 content 설정
@hyun99999 hyun99999 mentioned this issue May 9, 2022
Merged
hyun99999 added a commit that referenced this issue May 10, 2022
@hyun99999
Merge pull request #604 from hyun99999/release/#571
f608496 
[Refactor] #571 - SendSparkButton 이니셜라이저를 활용한 초기화로 리펙토링
@hyun99999 hyun99999 mentioned this issue May 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyun99999 hyun99999

Labels
👼타락pOwEr천사현규 크로아서버 환영요 👷Refactor👷‍♂️ 동작변화없이 내부구조 변경
Projects
None yet
Milestone
No milestone
1 participant
@hyun99999