Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 커스텀 탭바 구현 #351

Closed
3 tasks done
hyun99999 opened this issue Mar 7, 2022 · 0 comments · Fixed by #387
Closed
3 tasks done

[Feat] 커스텀 탭바 구현 #351

hyun99999 opened this issue Mar 7, 2022 · 0 comments · Fixed by #387
Assignees
@hyun99999
Labels
Feat 새로운 기능 구현 P1 / Priority High 👼타락pOwEr천사현규 크로아서버 환영요

Comments

@hyun99999
Copy link
Member

hyun99999 commented Mar 7, 2022 •
edited
Loading

🛠 Issue

  • 커스텀 탭바 구현
  • 홈에서 컬렉션뷰가 올라가있는 에러 해결하기

📝 To-do

  • 커스텀 탭바 구현
  • 프로젝트에 적용
  • 홈에서 scrollToItem 할때 bottom 으로 수정
@hyun99999 hyun99999 added Feat 새로운 기능 구현 👼타락pOwEr천사현규 크로아서버 환영요 P1 / Priority High labels Mar 7, 2022
@hyun99999 hyun99999 self-assigned this Mar 7, 2022
hyun99999 added a commit to hyun99999/Spark-iOS that referenced this issue Mar 14, 2022
@hyun99999
[Move] TeamSparker#351 - SparkNavigationBar 관련 파일 이동
2dbb847
hyun99999 added a commit to hyun99999/Spark-iOS that referenced this issue Mar 14, 2022
@hyun99999
[Add] TeamSparker#351 - SparkTabBar 생성 및 관련 Delegate 파일 분할
4e3f844
hyun99999 added a commit to hyun99999/Spark-iOS that referenced this issue Mar 14, 2022
@hyun99999
[Add] TeamSparker#351 - SparkTabBar 생성 및 관련 Delegate 파일 분할
6175b17
hyun99999 added a commit to hyun99999/Spark-iOS that referenced this issue Mar 14, 2022
@hyun99999
[Fix] TeamSparker#351 - HomeVC 컬렉션뷰 살짝 스크롤된 현상 해결
ccbbeeb 
- scrollToItem 속성을 bottom 으로 설정해줌
hyun99999 added a commit to hyun99999/Spark-iOS that referenced this issue Mar 14, 2022
@hyun99999
[Fix] TeamSparker#351 - SparkTabBarDelegate 메서드 네이밍 lowerCamelCase 적용
a350049
hyun99999 added a commit to hyun99999/Spark-iOS that referenced this issue Mar 14, 2022
@hyun99999
[Feat] TeamSparker#351 - tab bar 에서 item 역할을 할 SparkTabBarItem 생성 및 구현
c44ed5f
hyun99999 added a commit to hyun99999/Spark-iOS that referenced this issue Mar 14, 2022
@hyun99999
[Feat] TeamSparker#351 - tab bar 역할을 할 SparkTabBar 구현
e53b826
hyun99999 added a commit to hyun99999/Spark-iOS that referenced this issue Mar 14, 2022
@hyun99999
[Fix] TeamSparker#351 - SparkTabBar items 및 접근제한자 수정
a01196f
hyun99999 added a commit to hyun99999/Spark-iOS that referenced this issue Mar 14, 2022
@hyun99999
[Feat] TeamSparker#351 - tab bar controller 역할을 할 SparkTabBarControll…
22ab0d7 
…er 구현

- 인스펙터로 tint color 와 background color 를 설정할 수 있도록 함.
hyun99999 added a commit to hyun99999/Spark-iOS that referenced this issue Mar 14, 2022
@hyun99999
[Comment] TeamSparker#351 - modify SparkTabBar remark
beea379
hyun99999 added a commit to hyun99999/Spark-iOS that referenced this issue Mar 14, 2022
@hyun99999
[Comment] TeamSparker#351 - modify SparkTabBarController remark
808d245
hyun99999 added a commit to hyun99999/Spark-iOS that referenced this issue Mar 14, 2022
@hyun99999
[Feat] TeamSparker#351 - SparkTabBarController 상속받은 후 SparkTabBar 세팅
0e628df
@hyun99999 hyun99999 mentioned this issue Mar 14, 2022
Merged
hyun99999 added a commit to hyun99999/Spark-iOS that referenced this issue Mar 14, 2022
@hyun99999
[Merge] TeamSparker#351 - Merge branch 'develop' into `feature/TeamSp…
9f784a5 
…arker#351`

# Conflicts:
#	Spark-iOS/Spark-iOS/Source/ViewControllers/TabBar/HomeVC.swift
hyun99999 added a commit to hyun99999/Spark-iOS that referenced this issue Mar 15, 2022
@hyun99999
[Fix] TeamSparker#351 - 코드리뷰 반영
54c39c3 
- stack view 에 접근할 수 없도록 접근제한자 설정
hyun99999 added a commit to hyun99999/Spark-iOS that referenced this issue Mar 19, 2022
@hyun99999
Merge branch 'feature/TeamSparker#351' of https://github.com/hyun9999…
2d79db7 
…9/Spark-iOS; branch 'develop' of https://github.com/TeamSparker/Spark-iOS into feature/TeamSparker#351
hyun99999 added a commit that referenced this issue Mar 19, 2022
@hyun99999
Merge pull request #387 from hyun99999/feature/#351
0f975e7 
[Feat] #351 - 커스텀 탭바 구현
hyun99999 added a commit that referenced this issue Mar 19, 2022
@hyun99999
Revert "[Feat] #351 - 커스텀 탭바 구현"
84b7423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyun99999 hyun99999

Labels
Feat 새로운 기능 구현 P1 / Priority High 👼타락pOwEr천사현규 크로아서버 환영요
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feat] #351 - 커스텀 탭바 구현 hyun99999/Spark-iOS
1 participant
@hyun99999