closed ticket #84. showing error message on page for overlapping even… #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for overlapping events. new bug discovered with ticket TeamProductionSystem#104 made to resolve it on backend
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 9312e04 |
|
Need to fix a few more things. Error banner is just constant on page right now. |
GitLukeW
approved these changes
Aug 10, 2023
GitLukeW
added a commit
that referenced
this pull request
Sep 9, 2023
closed ticket #84. showing error message on page for overlapping even…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ts. new bug discovered with ticket #104 made to resolve it on backend
Pull Request Template
1. Targeted Issue
Return error message for overlapping event schedule
Ticket #84
2. Overview of Solution
Set .catch in axios request in TimeSlot.js with error.response.data
3. Tools Used
React and MUI
4. Testing Strategy
Trial and error with monitoring inspect tools, Network and Console.
5. Future Implications
We now display an error message to let the mentor know they have potential scheduling conflicts. Also discovered new bug and wrote ticket #104 on trello
6. Screenshots
(A picture is worth a thousand words. Include screenshots of your changes if relevant.)
7. Code Reviewers
(Who else is in the loop? Mention your team or other contributors here.)
Before you go...
Big high-fives for your incredible pull request! We're thrilled to have you as a contributor! Our team will dig into your proposed changes and give you some feedback or merge them if they're good to go. Your contributions mean the world to us!