Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

95 15 min notif #141

Merged
merged 7 commits into from
Aug 2, 2023
Merged

Conversation

esaintb
Copy link
Contributor

@esaintb esaintb commented Aug 2, 2023

Pull Request Template

1. Targeted Issue

Ticket # 94 -97

2. Overview of Solution

Allowed for mentors and mentees to receive email notifications 15 minutes and 60 minutes before meeting time

3. Tools Used

MUI, insomnia, React

4. Testing Strategy

Tested code response in insomnia through endpoints

5. Future Implications

Currently disabled, need to be turned on once the backend is running
Perhaps change the default notification to true

6. Screenshots

Screenshot 2023-08-02 at 2 32 23 PM Screenshot 2023-08-02 at 2 32 05 PM

7. Code Reviewers

@GitLukeW @nzeager @capelhoworth


Before you go...

  • [ y] I have linked the relevant issue
  • [ y] I have provided an overview of my solution
  • [ y] I have shared the tools I've used
  • [ y] I have outlined my testing strategy
  • [ y] I have considered future implications of my changes
  • [ y] I have included relevant screenshots
  • [ y] I have kept my team in the loop

Big high-fives for your incredible pull request! We're thrilled to have you as a contributor! Our team will dig into your proposed changes and give you some feedback or merge them if they're good to go. Your contributions mean the world to us!

@netlify
Copy link

netlify bot commented Aug 2, 2023

‼️ Deploy request for momentum-mentors rejected.

Name Link
🔨 Latest commit b03242c

Copy link
Contributor

@GitLukeW GitLukeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great. Thank you for not only getting this PR submitted, but also cleaning up some of the legacy code.

Approved and Merged!

@GitLukeW GitLukeW merged commit 38d5965 into TeamProductionSystem:main Aug 2, 2023
GitLukeW added a commit that referenced this pull request Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants