-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ART] new art for power cell and copper wire, fixed scaling problem with cell #1047
Conversation
…r cell (.xml file was not loaded and pixelPerUnit was ignored)
In the future, it's preferred that you keep art PRs limited to one sprite change each: https://github.com/TeamPorcupine/ProjectPorcupine/wiki/Standards-and-Conventions#art-pr-guideline @alexisfcote you made the original copper wire. What do you think? I think the power cell is a big improvement - even beyond the scaling being fixed. It's clearer what it is now. The copper wire could maybe be even more 'cartoony' to fit with the art style the other art seems to follow, but it's definitely an improvement in the right direction over what we have now. I'm inclined to say yes to both 👍 |
I definitely like the power cell more now, it doesn't look like a flat object. I'm not sure about the coper wire though. I looks kinda squished, but not necessarily bad though. |
@abackwood I resorted to replace copper wire just to get rid of that 64kB 'photo' of coper wire that was there before.. and ye, I agree, it's not perfect and should be changed later on |
@dusho new as of yesterday, so no biggie :P I like the new power cell! |
@dusho Also if you want to, feel free to join the discord. We discuss a lot for the art there :) Good work. Really like the cell and we can just keep the placeholder wire for now. :) |
A great improvement! One tiny bit of down is the use of so many colors. not that it looks bad more that a less color heavy palette will improve the sprites cohesiveness. The wish is that the different sprites will work better together - this would be no problem with one artist like in most indie games. I believe this will help more people contribute art/sprites, but I might be wrong. Looks good, keep up the hard work 👍 |
The wire is in the wrong prespective |
Was it decided if we wanted isometric perspective in the sprites? If yes that would mean no-rotation of furniture, items etc... |
Indeed, seems we must declare the perspective; top down or with a slight angle. |
should I try to change it then? |
@alexisfcote @Mizipzor maybe move the discussion on how art should be drawn to the #1073 issue - which you might object too, it being about art request. But where would an aspiring artist look to contribute but in a request for new art? |
@dusho what is the state of this PR? |
@dusho When was that latest 'after' picture made; before or after the change to the sprite's filtermode was made? |
uh.. not sure when was change to filtermode made.. PR is 6 days old and I haven't re-merged this with upstream as there were no conflicts |
looks weird with that 32x32 character.. 64x64 one is still in works, right.. also I saw some PR where walls had outlines as well.. |
It also looks weird as the walls and floor have a bunch of colors while other stuff have much less |
will close this one and put art as temp placeholders in my other PR ( #1084 ) |
new art for power cell and copper wire, fixed scaling problem in power cell (.xml file was not loaded and pixelPerUnit was ignored)
![scr_cell_before](https://cloud.githubusercontent.com/assets/12616499/18103963/2524e148-6ef9-11e6-9dc6-6e69284cc5c4.png)
![scr_cell_copper_wire](https://cloud.githubusercontent.com/assets/12616499/18103895/dee61d5a-6ef8-11e6-96ee-10fcde962e39.png)
before:
after: