Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually check boolean env vars #30

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Actually check boolean env vars #30

merged 1 commit into from
Oct 20, 2023

Conversation

Jeidnx
Copy link
Contributor

@Jeidnx Jeidnx commented Apr 7, 2023

Check if boolean env vars are either true or 1 instead of just checking if the env var exists.
I also ran cargo fmt so the code adheres to the rust standard

@Bnyro
Copy link
Member

Bnyro commented Aug 4, 2023

I'd prefer having a

fn check_env_bool(&str) -> bool {}

to use for uds and ipv4 instead of repeating the code.
And the formatting changes should probably be done in a different PR :)

@Bnyro Bnyro force-pushed the check_env branch 2 times, most recently from 4293952 to 151b107 Compare October 20, 2023 14:13
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :P

@Bnyro Bnyro enabled auto-merge October 20, 2023 14:14
@Bnyro Bnyro merged commit 63e5d77 into TeamPiped:main Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants