-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.19.0 blogpost #145
0.19.0 blogpost #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small typos and changes to grammar. Everything else seems decent.
Why do I even run a spell checker |
Co-Authored-By: opusforlife2 <[email protected]>
In general, I find the term "subscriptions" to be confusing. It should be replaced with "subscribed channels" everywhere in Newpipe documentation, I think, starting with this blog post, before it has a chance to propagate. |
Hmm, I don't really see what is confusing with this. Imo, they are interchangeable. |
Can you dismiss my stale reviews? They're taking up a lot of screen when scrolling. I'll start a new one. |
I agree with @Poolitzer |
But. I already did? Reload maybe. |
There are those that say "Outdated... Show Resolved". Those are collapsed. The ones that just say "Outdated" aren't collapsible. Edit: Ah. That's better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks to everyone involved!
@opusforlife2 Are you finished with your review or are you working on further improvements?
Working! Working! ALERT! |
Phew! Reviewing just text takes so long. I can't imagine how long it must take to review code! Kudos to you guys, seriously! |
Actually, its quite fast:
|
Co-Authored-By: opusforlife2 <[email protected]>
Co-Authored-By: Tobias Groza <[email protected]>
There you go. I guess the video needs compressing and we probably need to discuss if the screenshots are appropriate. Anyway, I added all of them in this zip. And give all the rights to NewPipe to use them or what I had to write the last time.
media.zip