Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.19.0 blogpost #145

Merged
merged 13 commits into from
Mar 29, 2020
Merged

0.19.0 blogpost #145

merged 13 commits into from
Mar 29, 2020

Conversation

Poolitzer
Copy link
Member

There you go. I guess the video needs compressing and we probably need to discuss if the screenshots are appropriate. Anyway, I added all of them in this zip. And give all the rights to NewPipe to use them or what I had to write the last time.

media.zip

Copy link
Contributor

@gkeegan gkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small typos and changes to grammar. Everything else seems decent.

_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
@Poolitzer
Copy link
Member Author

Just some small typos

Why do I even run a spell checker

_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
@opusforlife2
Copy link
Collaborator

In general, I find the term "subscriptions" to be confusing. It should be replaced with "subscribed channels" everywhere in Newpipe documentation, I think, starting with this blog post, before it has a chance to propagate.

@Poolitzer
Copy link
Member Author

Hmm, I don't really see what is confusing with this. Imo, they are interchangeable.

@opusforlife2
Copy link
Collaborator

Can you dismiss my stale reviews? They're taking up a lot of screen when scrolling. I'll start a new one.

@TobiGr
Copy link
Contributor

TobiGr commented Mar 29, 2020

I agree with @Poolitzer

@Poolitzer
Copy link
Member Author

Can you dismiss my stale reviews? They're taking up a lot of screen when scrolling. I'll start a new one.

But. I already did? Reload maybe.

@opusforlife2
Copy link
Collaborator

opusforlife2 commented Mar 29, 2020

There are those that say "Outdated... Show Resolved". Those are collapsed. The ones that just say "Outdated" aren't collapsible.

Edit: Ah. That's better.

Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks to everyone involved!

@opusforlife2 Are you finished with your review or are you working on further improvements?

@opusforlife2
Copy link
Collaborator

Working! Working! ALERT!

_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
_posts/2020-03-29-newpipe-0.19.0-released.md Outdated Show resolved Hide resolved
@opusforlife2
Copy link
Collaborator

Phew! Reviewing just text takes so long. I can't imagine how long it must take to review code! Kudos to you guys, seriously!

@Poolitzer
Copy link
Member Author

Poolitzer commented Mar 29, 2020

I can't imagine how long it must take to review code!

Actually, its quite fast:

  • tests dont fail
  • press review
  • upper right corner, write LGTM
  • hit approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants