-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse YouTube comments as HTML #928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
@AudricV feel free to merge these small PRs without waiting for my or anyone's approval ;-)
@Stypox I was not agree to merge this. Also, how NewPipe would handle this? It will probably display the comment with HTML tags. If we want to return HTML, we should generalize the |
Well then write a comment if you already thought about this... When I looked at this PR I didn't find any comment saying it should not be merged... Just like descriptions can come in many formats, can't comments do so too? |
Express that! Even if its just 1 line it helps.
Descriptions currently are also HTML? Currently, I think it may do that. I think it should be easy to fix that?
That could be done indeed. Would you like a PR for this? |
I didn't have the time to do so and then I forgot a bit this PR, sorry!
Yes, it would be great! |
That's fine, commits can be reverted anyway in case the Description PR takes some time ;-) |
This change is to add support for clickable timestamps and URLs.