[YouTube] Fix throttling parameter decryption on Android #925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally found out why the ThrottlingDecryptor keeps failing on NewPipe, while all extractor tests are passing.
Android apparently uses a different regex engine than regular java (see this SO thread https://stackoverflow.com/questions/45074813/regex-pattern-error-in-android-when-matching-closing-brace).
That's why the regex used to extract the nsig function fails to compile with a syntax error on android, unless you escape the curly brace with a slash.