Make improvements to methods using toArray(). #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Isira-Seneviratne
commented
Aug 4, 2022
Isira-Seneviratne
commented
- I carefully read the contribution guidelines and agree to them.
- I have tested the API against NewPipe.
Stypox
requested changes
Aug 4, 2022
Comment on lines
84
to
85
| final String[] keySet = kioskList.keySet().toArray(new String[0]); | ||
| return getExtractorById(keySet[0], nextPage, localization); |
There was a problem hiding this comment.
I think this can be improved, in order to avoid uselessly converting the list to an array (my code was not checked, improve it if there are warnings)
Suggested change
| final String[] keySet = kioskList.keySet().toArray(new String[0]); | |
| return getExtractorById(keySet[0], nextPage, localization); | |
| final String kioskId = kioskList.keySet().stream().findAny().get(); | |
| return getExtractorById(kioskId, nextPage, localization); |
| @@ -124,9 +125,7 @@ public static String[] getLinksFromString(final String txt) throws ParsingExcept | |||
| links.add(txt.substring(ls.getBeginIndex(), ls.getEndIndex())); | |||
| } | |||
|
|
|||
| String[] linksarray = new String[links.size()]; | |||
| linksarray = links.toArray(linksarray); | |||
| return linksarray; | |||
There was a problem hiding this comment.
I think this method is just unused... Should we remove it or keep it in case it becomes handy later? In the second case, just change the function signature and avoid converting links to an array
Isira-Seneviratne
force-pushed
the
toArray_improvements
branch
from
0ff0054 to
82a5768
Compare
Isira-Seneviratne
changed the title
Stypox
reviewed
Aug 5, 2022
extractor/src/main/java/org/schabi/newpipe/extractor/kiosk/KioskList.java
Outdated
Show resolved
Hide resolved
Isira-Seneviratne
force-pushed
the
toArray_improvements
branch
from
82a5768 to
7daca10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.