Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed hardcoded soundcloud HARDCODED_CLIENT_ID #815

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Removed hardcoded soundcloud HARDCODED_CLIENT_ID #815

merged 1 commit into from
Mar 17, 2022

Conversation

litetex
Copy link
Member

@litetex litetex commented Mar 15, 2022 •
edited
Loading

It never works (long enough) so let's simply remove it...

More why we should remove it points:

  1. It always fails after a month (because new id)
  2. We always have to update it and it breaks our tests
  3. No one benefits from this not even the users - maybe for ~2 weeks (since we usually have a 2 week pre-release testing period) but then it's useless as it's not up-to-date anymore...

Fixes #781

@litetex
Removed hardcoded soundcloud id
ba56be8 
It never works (long enough) so let's simply remove it...
@litetex litetex added the soundcloud service, https://soundcloud.com/ label Mar 15, 2022
@litetex litetex mentioned this pull request Mar 15, 2022
Closed
1 task
Stypox
Stypox approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also remove the hardcoded client id

@litetex litetex merged commit cc2e4d7 into TeamNewPipe:dev Mar 17, 2022
@litetex litetex deleted the fix-soundcloud-id-once-and-for-all branch March 17, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
soundcloud service, https://soundcloud.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate CI + test for hardcoded SoundCloud client ID
2 participants
@litetex @Stypox