Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YouTube] Fix music mixes in some countries #804

Merged
merged 1 commit into from
Mar 20, 2022

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Mar 1, 2022

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Fixes #788 (comment)

I have no idea if this really fixes the issue, but @opusforlife2 you could give it a try, here is an APK: app-debug.zip ;-)

@AudricV AudricV added bug Issue is related to a bug youtube service, https://www.youtube.com/ labels Mar 1, 2022
@opusforlife2
Copy link
Collaborator

Ahaha... It 'fixed' the problem in an unexpected way. Now there are no more Mixes to even get an error. 😆

@Stypox
Copy link
Member Author

Stypox commented Mar 4, 2022

@opusforlife2 well, just share a mix from the other app from #788 or directly from youtube ;-)

@opusforlife2
Copy link
Collaborator

Ah. Success!

@Stypox
Copy link
Member Author

Stypox commented Mar 4, 2022

Oh, great, I didn't really except this fix to work ;-)
Then this PR is ready

@opusforlife2
Copy link
Collaborator

Shouldn't this code be merged into the other PR? I've never seen an unmerged PR being fixed by another PR. You guys usually force-push.

@Stypox
Copy link
Member Author

Stypox commented Mar 6, 2022

@opusforlife2 no, this PR fixes mixes in general (mixes already existed and worked), it has nothing to do with the other PR that adds mixes to related items

@Stypox
Copy link
Member Author

Stypox commented Mar 19, 2022

@XiangRongLin could you also review and merge this, please?

@XiangRongLin XiangRongLin merged commit aa6b727 into TeamNewPipe:dev Mar 20, 2022
@opusforlife2
Copy link
Collaborator

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug youtube service, https://www.youtube.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants