Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored YoutubeCommentsExtractor #799

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Refactored YoutubeCommentsExtractor #799

merged 2 commits into from
Feb 23, 2022

Conversation

litetex
Copy link
Member

@litetex litetex commented Feb 13, 2022

@litetex litetex added the youtube service, https://www.youtube.com/ label Feb 13, 2022
Stypox
Stypox requested changes Feb 19, 2022
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java Outdated Show resolved Hide resolved
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java Outdated Show resolved Hide resolved
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java Outdated Show resolved Hide resolved
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java Show resolved Hide resolved
@litetex
Refactored YoutubeCommentsExtractor
f79ce1f 
* Use Java Streaming API
* Use StandardCharsets
* Prevented several NPEs/ArrayIndexOutOfBound
* Reformatted some code so that it's easier readable
@litetex
Refactored code
1a67ea1 
according to review
@litetex litetex force-pushed the imporve-yt-comments-extractor branch from ce65dc0 to 1a67ea1 Compare February 21, 2022 18:56
@Stypox Stypox merged commit 69e18c8 into TeamNewPipe:dev Feb 23, 2022
@litetex litetex deleted the imporve-yt-comments-extractor branch February 23, 2022 18:45
@opusforlife2 opusforlife2 mentioned this pull request Apr 8, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@litetex @Stypox