Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUnit 5 #768

Merged
merged 10 commits into from
Jan 24, 2022
Merged

JUnit 5 #768

merged 10 commits into from
Jan 24, 2022

Conversation

litetex
Copy link
Member

@litetex litetex commented Dec 27, 2021

  • This PR drops JUnit 4 and introduces the new and improved JUnit 5.
  • Minor code reworks and fixes on the fly

@litetex litetex marked this pull request as ready for review January 2, 2022 18:47
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

* Deprecated Utils#UTF-8; see StandardCharsets
* Added more helpful methods to ``ExtractorAsserts``
* Use parameterized (cool new) tests
* Restore functionality of some tests + updated mockdata
* Other code cleanups + Sonarlint improvements
@litetex litetex changed the title Junit 5 JUnit 5 Jan 4, 2022
@litetex
Copy link
Member Author

litetex commented Jan 19, 2022

@Stypox Ping

@opusforlife2 opusforlife2 requested a review from Stypox January 21, 2022 18:18
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Tests pass and they have been well converted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants