Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verified info to ChannelInfo. #714

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

FireMasterK
Copy link
Member

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

@XiangRongLin
Copy link
Collaborator

Am i seeing it correctly that this is just adding the field and that parsing and filling that field will still need to be done?

@FireMasterK
Copy link
Member Author

They're already parsed in the extractor, I'm just adding it since I don't use extractor/extractions API directly in Piped, but I directly use ChannelInfo.getInfo(url).

Copy link
Collaborator

@XiangRongLin XiangRongLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, i missed that the class is creating itself with the static methods.

@XiangRongLin XiangRongLin merged commit 4f86b8c into TeamNewPipe:dev Aug 17, 2021
@FireMasterK FireMasterK deleted the verified-channelinfo branch August 17, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants