Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getMixUrl method to StreamExtractors #685

Closed
wants to merge 1 commit into from

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Jul 19, 2021

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

I added the getMixUrl(MixType) method to every StreamExtractor, along with an enum for mix types (video, music, channel, album), following TeamNewPipe/NewPipe#3583 (comment). This PR is a draft and still needs work, also the frontend UI is still a TODO, but feel free to give feedback ;-).

Fixes TeamNewPipe/NewPipe#3583
Fixes TeamNewPipe/NewPipe#3250

@Stypox Stypox marked this pull request as draft July 19, 2021 20:30
@Stypox
Copy link
Member Author

Stypox commented Jul 20, 2021

@XiangRongLin YouTube mixes seem to work randomly: for some videos they exist, for some others they do not. I'd switch to the other approach of returning a MultiInfoItemsCollector from streamInfo.getRelatedItems(), with available mixes and all other related videos. The only problem here is that strings cannot be translated, but I'd just use the mix name provided by youtube and call it a day (e.g. "Mix – NoCopyrightSounds"), since that's the name used in MixPlaylistExtractor too.

@opusforlife2
Copy link
Collaborator

Yay! Youtube Music mixes! 💃

@opusforlife2
Copy link
Collaborator

Youtube Music mixes...

@Stypox
Copy link
Member Author

Stypox commented Feb 2, 2022

Closing in favor of #788

@Stypox Stypox closed this Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start YouTube Mix from inside NewPipe [Feature Request] Support Youtube Music mixes
2 participants