Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle to 7.1.1 #682

Closed
wants to merge 1 commit into from
Closed

Upgrade Gradle to 7.1.1 #682

wants to merge 1 commit into from

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Jul 12, 2021

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Upgrade Gradle to 7.1.1

Closes TeamNewPipe/NewPipe#6651

Todo:

  • check if anything broke
  • Go though upgrade guide and check deprecations / API changes

@litetex
Copy link
Member

litetex commented Jul 17, 2021

LGTM

Can this be switched to "ready for reviewing" or are there any things speaking against it?

@TobiGr
Copy link
Contributor Author

TobiGr commented Jul 17, 2021

I did not have time to check the upgrade notes. Will do it later

@XiangRongLin
Copy link
Collaborator

@TacoTheDank do you have time to do this? since you already went through this process once, you should know what to look out for

@TacoTheDank
Copy link
Member

@XiangRongLin Sorry for late reply. Sure, I'll look into it :) should I do a separate PR?

@TobiGr
Copy link
Contributor Author

TobiGr commented Jul 19, 2021

@TacoTheDank Feel free to do so

@TacoTheDank TacoTheDank mentioned this pull request Jul 20, 2021
1 task
@TacoTheDank
Copy link
Member

@TobiGr this can be closed, I believe

@TobiGr TobiGr closed this Aug 8, 2021
@TobiGr TobiGr deleted the gradle branch August 8, 2021 13:04
@TobiGr
Copy link
Contributor Author

TobiGr commented Aug 8, 2021

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using local extractor fails due to different gradle major version
4 participants