Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ucbcb=1 parameter #669

Closed
wants to merge 1 commit into from
Closed

Add ucbcb=1 parameter #669

wants to merge 1 commit into from

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented Jun 25, 2021

It prevents two requests related to consent on every video to request comments:

Before:

  1. m.youtube.com/watch?v=ID
  2. consent.youtube.com/m?continue=URL
  3. m.youtube.com/watch?v=ID&ucbcb=1
  4. m.youtube.com/watch_comment?ctoken=…

Now.

  1. m.youtube.com/watch?v=ID&ucbcb=1
  2. m.youtube.com/watch_comment?ctoken=…
  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

It prevents two requests related to consent
@B0pol B0pol added enhancement New feature or request youtube service, https://www.youtube.com/ labels Jun 25, 2021
@TobiGr
Copy link
Contributor

TobiGr commented Jun 26, 2021

you need to update the mocks

@litetex
Copy link
Member

litetex commented Aug 24, 2021

Can this be closed due to the usage of the new YT API?
#604

@AudricV
Copy link
Member

AudricV commented Aug 24, 2021

@litetex Yes, it has been also added when extracting the client version and the API key from a YouTube HTML page here: https://github.com/TeamNewPipe/NewPipeExtractor/blob/dev/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeParsingHelper.java#L301.

So, like you said, this can be closed. Closing this PR.

@AudricV AudricV closed this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request youtube service, https://www.youtube.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants