Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YouTube] fix tests #608

Merged
merged 3 commits into from
May 1, 2021
Merged

[YouTube] fix tests #608

merged 3 commits into from
May 1, 2021

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Apr 11, 2021

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

[YouTube] Replace unavailable YouTube Stream Segments test. The stream is unavailable in many countries.

@TobiGr TobiGr added the youtube service, https://www.youtube.com/ label Apr 11, 2021
@TobiGr TobiGr changed the title [Youtube] fix segment test [Youtube] fix tests Apr 11, 2021
@XiangRongLin
Copy link
Collaborator

Kind of unrelated, but is it even necessary to have hierarchical tests by inheriting from DefaultStreamExtractorTest. The tests is intendet to have check if the stream segments are parsed correctly, which is done with testStreamSegment0 and testStreamSegment3. All the other tests are redundant, since that functionality is alread covered by other tests

@AudricV AudricV changed the title [Youtube] fix tests [YouTube] fix tests Apr 13, 2021
@TobiGr TobiGr merged commit 284362f into dev May 1, 2021
@TobiGr TobiGr deleted the youtube-fix-segment-test branch May 1, 2021 15:24
@triallax triallax mentioned this pull request May 23, 2021
Closed
@ShareASmile ShareASmile mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiangRongLin XiangRongLin XiangRongLin approved these changes

Assignees
No one assigned
Labels
youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TobiGr @XiangRongLin