Fix a test and ignore rest #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
XiangRongLin
commented
Apr 2, 2021
•
XiangRongLin
commented
- I carefully read the contribution guidelines and agree to them.
- I have tested the API against NewPipe.
- I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.
XiangRongLin
force-pushed
the
fix_tests
branch
3 times, most recently
from
3d6502d to
7931873
Compare
Stypox
requested changes
Apr 2, 2021
.../test/java/org/schabi/newpipe/extractor/services/peertube/PeertubePlaylistExtractorTest.java
Show resolved
Hide resolved
| @@ -31,6 +33,13 @@ public static void setUp() throws Exception { | |||
| extractor.fetchPage(); | |||
| } | |||
|
|
|||
| @Override | |||
| @Test | |||
| @Ignore("When visiting website it shows 'Lofi Girl', unknown why it's different in tests") | |||
There was a problem hiding this comment.
The channel underwent a name change, maybe, and then reverted? Or it has to do with the verification process? Btw if I open the stream in NewPipe now I correctly get "Lofi Girl", it could depend on the country. Let's leave it ignored
3 tasks
TobiGr
approved these changes
Apr 3, 2021
Stypox
approved these changes
Apr 3, 2021
This was referenced Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.