[YouTube] Fix missing comments under videos #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed tests seem to concern parts of the code which this PR does not alter; I am not sure why it is failing. |
TobiGr
approved these changes
Mar 5, 2021
|
Thank you! |
TobiGr
added
bug
AudricV
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TeamNewPipe/NewPipe#5585, TeamNewPipe/NewPipe#5757, TeamNewPipe/NewPipe#5759.
It seems youtube is in the process of slightly changing their API, and the comment extractor could no longer find the ctoken. Based on reports that the old way sometimes worked, I left it in as an option. I have tested it on my phone and the app works correctly with this change.