Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set extractor encoding to UTF-8 #557

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

AudricV
Copy link
Member

@AudricV AudricV commented Feb 23, 2021

When compiling the extractor on Windows, you get more than 100 errors with the error message: error: unmappable character for encoding Cp1252, especially in timeago-parser tasks. This PR fixes it by setting the encoding for all compileJava and compileTestJava tasks to UTF-8.

When compiling the extractor on Windows, you get more than 100 errors with the message error: unmappable character for encoding Cp1252, especially in timeago-parser tasks. This commit fixes it by setting the encoding for all compileJava and compileTestJava tasks to UTF-8.
@TobiGr TobiGr merged commit 965a66b into TeamNewPipe:dev Feb 24, 2021
@AudricV AudricV deleted the fix-encoding-errors-windows branch February 24, 2021 15:19
@XiangRongLin
Copy link
Collaborator

XiangRongLin commented Feb 24, 2021

This means i can finally get error free gradle builds!????!!! 🥳

@AudricV AudricV added the enhancement New feature or request label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants