Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support /watch/, /v/ and /w/ subpaths #536

Merged
merged 5 commits into from
Feb 16, 2021
Merged

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented Feb 10, 2021

fixes #534 fixes TeamNewPipe/NewPipe#4283

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

I trust the tests

@B0pol B0pol added bug Issue is related to a bug youtube service, https://www.youtube.com/ labels Feb 10, 2021
@B0pol B0pol changed the title support /watch/ and /v/ folders support /watch/, /v/ and /w/ folders Feb 13, 2021
@B0pol B0pol force-pushed the watchendpoints branch 2 times, most recently from b42ddff to 38d1138 Compare February 13, 2021 10:23
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. two small things.

@B0pol B0pol changed the title support /watch/, /v/ and /w/ folders support /watch/, /v/ and /w/ subpaths Feb 13, 2021
@B0pol B0pol requested a review from TobiGr February 15, 2021 17:44
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…youtube/linkHandler/YoutubeStreamLinkHandlerFactory.java

Co-authored-by: Stypox <[email protected]>
@B0pol B0pol merged commit 84380e4 into TeamNewPipe:dev Feb 16, 2021
@B0pol B0pol deleted the watchendpoints branch February 18, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug youtube service, https://www.youtube.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support youtube.com/v/videoId Support Youtube shortened url
3 participants