-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support /watch/, /v/ and /w/ subpaths #536
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B0pol
added
bug
Issue is related to a bug
youtube
service, https://www.youtube.com/
labels
Feb 10, 2021
B0pol
force-pushed
the
watchendpoints
branch
from
February 10, 2021 16:09
d01c368
to
086ef29
Compare
B0pol
changed the title
support /watch/ and /v/ folders
support /watch/, /v/ and /w/ folders
Feb 13, 2021
B0pol
force-pushed
the
watchendpoints
branch
2 times, most recently
from
February 13, 2021 10:23
b42ddff
to
38d1138
Compare
TobiGr
reviewed
Feb 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. two small things.
...g/schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeStreamLinkHandlerFactory.java
Outdated
Show resolved
Hide resolved
...g/schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeStreamLinkHandlerFactory.java
Outdated
Show resolved
Hide resolved
B0pol
force-pushed
the
watchendpoints
branch
from
February 13, 2021 21:20
38d1138
to
8db40db
Compare
B0pol
changed the title
support /watch/, /v/ and /w/ folders
support /watch/, /v/ and /w/ subpaths
Feb 13, 2021
B0pol
force-pushed
the
watchendpoints
branch
from
February 13, 2021 21:26
90b9098
to
ee2012c
Compare
Stypox
requested changes
Feb 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...g/schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeStreamLinkHandlerFactory.java
Outdated
Show resolved
Hide resolved
…youtube/linkHandler/YoutubeStreamLinkHandlerFactory.java Co-authored-by: Stypox <[email protected]>
B0pol
force-pushed
the
watchendpoints
branch
from
February 16, 2021 18:17
0b036ed
to
41f689b
Compare
Stypox
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #534 fixes TeamNewPipe/NewPipe#4283
I trust the tests