Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adaptive Stream parsing #535

Merged
merged 15 commits into from
Feb 18, 2021
Merged

Adaptive Stream parsing #535

merged 15 commits into from
Feb 18, 2021

Conversation

FireMasterK
Copy link
Member

@FireMasterK FireMasterK commented Feb 10, 2021 •
edited
Loading

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

This will help me to create working dash manifests.

Closes #461 when complete.

What's left:

  • Read from for the dash/mpv parser too (I will probably create another PR for this)

@FireMasterK FireMasterK changed the title [WIP] Adaptive parsing [WIP] Adaptive Stream parsing Feb 10, 2021
@FireMasterK FireMasterK marked this pull request as ready for review February 11, 2021 09:11
@FireMasterK FireMasterK changed the title [WIP] Adaptive Stream parsing Adaptive Stream parsing Feb 11, 2021
@B0pol
Copy link
Member

B0pol commented Feb 11, 2021

Hmm did you think about other extractors? PeertubeStreamExtractor, SoundcloudStreamExtractor, MediaCCCStreamExtractor, can these additional information be extracted?

@FireMasterK
Copy link
Member Author

FireMasterK commented Feb 12, 2021 •
edited
Loading

So after yesterdays discussion:

  • Peertube requires another request for this information. (which we want to avoid as it's not required since the streams are already muxed)
  • MediaCCC does not provide this information and the streams are already muxed
  • For SoundCloud, nothing is provided, even in the HLS manifest.

@TobiGr TobiGr added the enhancement New feature or request label Feb 12, 2021
@FireMasterK
Copy link
Member Author

FireMasterK commented Feb 18, 2021 •
edited by B0pol
Loading

@B0pol anything else to be changed?

If not, you could approve these changes :D

@B0pol B0pol merged commit db253e2 into TeamNewPipe:dev Feb 18, 2021
@FireMasterK FireMasterK deleted the adaptive-parsing branch February 18, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr left review comments

@B0pol B0pol B0pol approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FireMasterK @B0pol @TobiGr