Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uploader verified by service extraction #521

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Add uploader verified by service extraction #521

merged 1 commit into from
Feb 18, 2021

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented Jan 22, 2021

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

TobiGr
TobiGr suggested changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement the expectedVerified methods in the default*Tests.
Btw. I assigned that issue to me, so most of that is implemented. You can have a look here: TobiGr@b772d5d ...

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeParsingHelper.java Outdated Show resolved Hide resolved
@B0pol
Copy link
Member Author

B0pol commented Jan 22, 2021

Sorry, I did not notice that.
I think we should keep this PR, there is SoundCloud implementation, artist verified badge, extracted in comments and channel…
I will push the defaultTests soon and let you implement the NewPipe part then.

@TobiGr
Copy link
Contributor

TobiGr commented Jan 22, 2021

Yes, we should use your implementation. I did not have time to finish everything yet (notice the incomplete JDoc, some missing tests, etc.).
As I said, I won't have much time for NewPipe in the next weeks. You can use the changes from my commit and apply them to your PR.

@B0pol
Copy link
Member Author

B0pol commented Jan 22, 2021

Please implement the expectedVerified methods in the default*Tests.

Done.

@B0pol B0pol requested a review from TobiGr January 22, 2021 23:00
@B0pol B0pol added enhancement New feature or request multiservice Issues related to multiple services labels Jan 22, 2021
@B0pol B0pol force-pushed the verified branch 2 times, most recently from bf7bd88 to 67a6642 Compare February 18, 2021 15:26
@B0pol B0pol merged commit 9c1a7f7 into TeamNewPipe:dev Feb 18, 2021
@B0pol B0pol deleted the verified branch February 18, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiangRongLin XiangRongLin XiangRongLin left review comments

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request multiservice Issues related to multiple services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@B0pol @TobiGr @XiangRongLin