Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OkHttp for tests like in NewPipe #349

Merged
merged 1 commit into from
Jun 27, 2020
Merged

Use OkHttp for tests like in NewPipe #349

merged 1 commit into from
Jun 27, 2020

Conversation

wb9688
Copy link
Contributor

@wb9688 wb9688 commented Jun 11, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

@wb9688 wb9688 added this to the 0.19.6 milestone Jun 11, 2020
extractor/build.gradle Show resolved Hide resolved
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@Stypox did you finish your review?

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks good to me

@Stypox
Copy link
Member

Stypox commented Jun 27, 2020

@TobiGr I wasn't able to merge it due to the failing Travis CI, but I already added the PR to the release notes. So just merge ;-)

@TobiGr TobiGr merged commit 339f1d9 into TeamNewPipe:dev Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants