-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PeerTube] channels support #308
Conversation
extractor/src/main/java/org/schabi/newpipe/extractor/services/peertube/PeertubeService.java
Outdated
Show resolved
Hide resolved
...chabi/newpipe/extractor/services/peertube/linkHandler/PeertubeChannelLinkHandlerFactory.java
Outdated
Show resolved
Hide resolved
...va/org/schabi/newpipe/extractor/services/peertube/PeertubeChannelLinkHandlerFactoryTest.java
Show resolved
Hide resolved
...va/org/schabi/newpipe/extractor/services/peertube/PeertubeChannelLinkHandlerFactoryTest.java
Show resolved
Hide resolved
.../src/test/java/org/schabi/newpipe/extractor/services/peertube/PeertubeUserExtractorTest.java
Outdated
Show resolved
Hide resolved
...in/java/org/schabi/newpipe/extractor/services/peertube/extractors/PeertubeUserExtractor.java
Outdated
Show resolved
Hide resolved
* Rename PeertubeUserExtractor to PeertubeAccountExtractor * Add test for video-channels in PeertubeChannelLinkHandlerFactoryTest * Compatibility support for older versions (use "accounts/" as default)
@Royosef: You forgot to address #308 (comment) |
I added the following test: Was I supposed to add something else? |
@Royosef: You was supposed to add that, but also tests for getting the URL from the ID. Those tests are for getting the ID from the URL. |
Oh, do you mean the acceptUrlTest function in PeertubeChannelLinkHandlerFactoryTest? I will add a test for video-channels there. |
@Royosef: No, I meant that you should add something like:
Note that I didn't test whether this example works, and you should add all 3 cases. You're correct in that you also need to add a video channel to the |
add support for peertube channels