Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD basic playlist support + youtube playlist support #2

Merged
merged 2 commits into from
Mar 21, 2017

Conversation

BlenderViking
Copy link
Contributor

Hi,

I begin the refactor of my previous pull request : TeamNewPipe/NewPipe#377

To avoid the same problem as previously encountered (to big code base change), I begin to submit multiple small pull request.

To avoid the same problem as previously encountered, I will send the code by multiple small pull request.

So here the code for import an external playlist in the core extractor app.

I made a unit test but I didn't found how to commit it in the core part.
So i made a gist for store it : https://gist.github.com/BlenderViking/c73c6776580ed661f78f6b0739a66e73

@theScrabi
Copy link
Member

The unit tests are still part of the NewPipe app itself.

Nice work. :)

Copy link
Member

@theScrabi theScrabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right looks fine to me so far :) Just one small thing:

@@ -52,8 +52,11 @@ public abstract StreamExtractor getExtractorInstance(String url)
public abstract SearchEngine getSearchEngineInstance();
public abstract UrlIdHandler getStreamUrlIdHandlerInstance();
public abstract UrlIdHandler getChannelUrlIdHandlerInstance();
public abstract UrlIdHandler getPlayListUrlIdHandlerInstance();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the spacing.

@BlenderViking
Copy link
Contributor Author

BlenderViking commented Mar 21, 2017

Ok, It's fixed :)
I just a question, how to correctly map the git submodules on Android Studio in the main project ?

@theScrabi
Copy link
Member

Ow good question, I did it using the command line.

@theScrabi theScrabi merged commit 281d23d into TeamNewPipe:master Mar 21, 2017
@theScrabi
Copy link
Member

theScrabi commented Mar 22, 2017

I've updated the extractor repository.
I think with git submodules update you can update it now on your side.
However if you want to update it (by means you want to create the commit where it gets updated) you have to go to the submodules repo, and do a git pull origin master.

@BlenderViking
Copy link
Contributor Author

BlenderViking commented Mar 25, 2017

I found, after clone the repos, we just need to tape in command line :
The init the submodule :

git submodule init
git submodule update --recursive --remote

And then in AndroidStudio define in the git config the submodule :
submodule integration
And we can see the repos of the submodule in Android Studio :
image

@theScrabi
Copy link
Member

ah alright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants