-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD basic playlist support + youtube playlist support #2
Conversation
The unit tests are still part of the NewPipe app itself. Nice work. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right looks fine to me so far :) Just one small thing:
StreamingService.java
Outdated
@@ -52,8 +52,11 @@ public abstract StreamExtractor getExtractorInstance(String url) | |||
public abstract SearchEngine getSearchEngineInstance(); | |||
public abstract UrlIdHandler getStreamUrlIdHandlerInstance(); | |||
public abstract UrlIdHandler getChannelUrlIdHandlerInstance(); | |||
public abstract UrlIdHandler getPlayListUrlIdHandlerInstance(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the spacing.
Ok, It's fixed :) |
Ow good question, I did it using the command line. |
I've updated the extractor repository. |
ah alright |
Hi,
I begin the refactor of my previous pull request : TeamNewPipe/NewPipe#377
To avoid the same problem as previously encountered (to big code base change), I begin to submit multiple small pull request.
To avoid the same problem as previously encountered, I will send the code by multiple small pull request.
So here the code for import an external playlist in the core extractor app.
I made a unit test but I didn't found how to commit it in the core part.
So i made a gist for store it : https://gist.github.com/BlenderViking/c73c6776580ed661f78f6b0739a66e73