-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PeerTube] Add support for PeerTube v6 features #1142
Conversation
01b44a9
to
1330c4b
Compare
.../java/org/schabi/newpipe/extractor/services/peertube/extractors/PeertubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
I don't think you need to do breaking changes. Can't you catch errors when getting thumbnails and chapters like done for description and throwing an |
.../java/org/schabi/newpipe/extractor/services/peertube/extractors/PeertubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
.../java/org/schabi/newpipe/extractor/services/peertube/extractors/PeertubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it against current newpipe with the example videos and it seems to work pretty well.
It always jumps to the beginning when I select a chapter cause the timestamp is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check timestamps
.../java/org/schabi/newpipe/extractor/services/peertube/extractors/PeertubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
@Profpatsch Please edit comments to add more info instead of making multiple consecutive comments. |
In what way is that relevant? |
Implement PeerTubeStreamExtractor.getFrames()
@Profpatsch Thank you for the review! (I hope that we will be able to review your PRs soon)
Usually there is a large number of comments on all NewPipe repos, many people get notified about comments and thus receive notifications about new comments. Some team members do community management and therefore check all the new comments on information which might be important for other team members to check out asap. However, if there is no or just little new info in a comment, they waste their time. For that reason we try to motivate people to edit their comments when they want to add minor details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I tested and it works. Thank you!
Neither of these features are working for me using the listed test videos on 0.27.0 RC1. |
The RC uses @AudricV's yt-fix_comments_extraction branch which is 23 commits behind TeamNewPipe/NewPipeExtractor dev |
Is there a reason it's not up to date? Bit weird to have people test an RC that doesn't have all the features we claim it does. |
I guess the reason is that I didn't notice that |
Could you do that and compile another RC? |
Yes, I will for sure for the next RC |
Description
PeerTube 6.0.0 added support for multiple new features which are implemented in this PR:
PeerTubeStreamExtractor.getStreamSegments()
PeerTubeStreamExtractor.getFrames()
Videos for testing