Legitimately suppress remaining checkstyle warnings

TeamNewPipe · Mar 18, 2022 · 494fec2 · 494fec2
1 parent 9ee52ae
commit 494fec2
Show file tree

Hide file tree

Showing 7 changed files with 22 additions and 2 deletions.
diff --git a/checkstyle/suppressions.xml b/checkstyle/suppressions.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0"?>
+<!DOCTYPE suppressions PUBLIC
+  "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+  "https://checkstyle.org/dtds/suppressions_1_2.dtd">
+<suppressions>
+  <!-- Use @SuppressWarnings("...") if it is possible, only use this file if it is not -->
+
+  <suppress checks="LineLength"
+    files="BandcampExtractorHelper.java"
+    lines="54"/>
+
+  <suppress checks="LineLength"
+    files="ItagItem.java"
+    lines="19"/>
+</suppressions>
diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/MediaFormat.java b/extractor/src/main/java/org/schabi/newpipe/extractor/MediaFormat.java
@@ -29,6 +29,7 @@
  * Static data about various media formats support by NewPipe, eg mime type, extension
  */
 
+@SuppressWarnings("MethodParamPad") // we want the media format table below to be aligned
 public enum MediaFormat {
     // @formatter:off
     //video and audio combined formats

diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/ServiceList.java b/extractor/src/main/java/org/schabi/newpipe/extractor/ServiceList.java
@@ -31,6 +31,7 @@
 /**
  * A list of supported services.
  */
+@SuppressWarnings({"ConstantName", "InnerAssignment"}) // keep unusual names and inner assignments
 public final class ServiceList {
     private ServiceList() {
         //no instance

diff --git a/...c/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeThrottlingDecrypter.java b/...c/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeThrottlingDecrypter.java
@@ -39,8 +39,8 @@ public class YoutubeThrottlingDecrypter {
             "b=a\\.get\\(\"n\"\\)\\)&&\\(b=(\\S+)\\(b\\),a\\.set\\(\"n\",b\\)");
 
     private static final Map<String, String> N_PARAMS_CACHE = new HashMap<>();
-    private static String FUNCTION;
-    private static String FUNCTION_NAME;
+    @SuppressWarnings("StaticVariableName") private static String FUNCTION;
+    @SuppressWarnings("StaticVariableName") private static String FUNCTION_NAME;
 
     private final String functionName;
     private final String function;

diff --git a/...org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeMusicSearchExtractor.java b/...org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeMusicSearchExtractor.java
@@ -279,6 +279,7 @@ public InfoItemsPage<InfoItem> getPage(final Page page)
         return new InfoItemsPage<>(collector, getNextPageFrom(continuations));
     }
 
+    @SuppressWarnings("MethodLength")
     private void collectMusicStreamsFrom(final InfoItemsSearchCollector collector,
                                          @Nonnull final JsonArray videos) {
         final TimeAgoParser timeAgoParser = getTimeAgoParser();

diff --git a/...chabi/newpipe/extractor/services/youtube/linkHandler/YoutubeStreamLinkHandlerFactory.java b/...chabi/newpipe/extractor/services/youtube/linkHandler/YoutubeStreamLinkHandlerFactory.java
@@ -81,6 +81,7 @@ public String getUrl(final String id) {
         return "https://www.youtube.com/watch?v=" + id;
     }
 
+    @SuppressWarnings("AvoidNestedBlocks")
     @Override
     public String getId(final String theUrlString)
             throws ParsingException, IllegalArgumentException {

diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfo.java b/extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfo.java
@@ -211,6 +211,7 @@ private static void extractStreams(final StreamInfo streamInfo, final StreamExtr
         }
     }
 
+    @SuppressWarnings("MethodLength")
     private static void extractOptionalData(final StreamInfo streamInfo,
                                             final StreamExtractor extractor) {
         /* ---- optional data goes here: ---- */