Merge pull request #843 from TiA4f8R/fix-checkstyle-issues

Remove Checkstyle suppressions file and fix Checkstyle issues
TeamNewPipe · May 2, 2022 · 23fa31a · 23fa31a
2 parents 2e1c5c1 + 3c3cd78
commit 23fa31a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 23 deletions.
diff --git a/checkstyle/checkstyle.xml b/checkstyle/checkstyle.xml
@@ -20,12 +20,6 @@
         <property name="fileNamePattern" value="module\-info\.java$"/>
     </module>
 
-    <!-- https://checkstyle.org/config_filters.html#SuppressionFilter -->
-    <module name="SuppressionFilter">
-        <property name="file" value="${config_loc}/suppressions.xml" />
-        <property name="optional" value="true"/>
-    </module>
-
     <!-- Checks that a package-info.java file exists for each package.     -->
     <!-- See https://checkstyle.org/config_javadoc.html#JavadocPackage -->
     <!--<module name="JavadocPackage"/>-->
@@ -68,6 +62,8 @@
 
     <module name="SuppressWarningsFilter" />
 
+    <module name="SuppressWithPlainTextCommentFilter"/>
+
     <module name="TreeWalker">
         <!-- Checks for Javadoc comments.                     -->
         <!-- See https://checkstyle.org/config_javadoc.html -->

diff --git a/checkstyle/suppressions.xml b/checkstyle/suppressions.xml
diff --git a/...va/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampExtractorHelper.java b/...va/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampExtractorHelper.java
@@ -54,7 +54,8 @@ public static String getStreamUrlFromIds(final long bandId,
 
     /**
      * Fetch artist details from mobile endpoint.
-     * <a href=https://notabug.org/fynngodau/bandcampDirect/wiki/rewindBandcamp+%E2%80%93+Fetching+artist+details>
+     * <a href="https://notabug.org/fynngodau/bandcampDirect/wiki/
+     * rewindBandcamp+%E2%80%93+Fetching+artist+details">
      * More technical info.</a>
      */
     public static JsonObject getArtistDetails(final String id) throws ParsingException {

diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/ItagItem.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/ItagItem.java
@@ -18,7 +18,7 @@
 public class ItagItem {
     /**
      * List can be found here
-     * https://github.com/ytdl-org/youtube-dl/blob/9fc5eafb8e384453a49f7cfe73147be491f0b19d/youtube_dl/extractor/youtube.py#L1071
+     * https://github.com/ytdl-org/youtube-dl/blob/9fc5eaf/youtube_dl/extractor/youtube.py#L1071
      */
     private static final ItagItem[] ITAG_LIST = {
             /////////////////////////////////////////////////////