Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrong annotation #9872

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Remove wrong annotation #9872

merged 1 commit into from
Mar 18, 2023

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Mar 1, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

The current release PR is failing the sonar lint quality quard. This PR removes the wrong annotation to make sonar lint happy:

Do not use @Nullable in Kotlin; the nullability is determined by the Kotlin type View.OnClickListener not ending with ? which declares it not nullable, contradicting the annotation

(see https://sonarcloud.io/project/issues?resolved=false&sinceLeakPeriod=true&types=BUG&pullRequest=9869&id=TeamNewPipe_NewPipe&open=AYacpIb_J93zs3Jn_4eI)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@TobiGr TobiGr added the codequality Improvements to the codebase to improve the code quality label Mar 1, 2023
@AudricV
Copy link
Member

AudricV commented Mar 1, 2023

> Task :app:runKtlint
/home/runner/work/NewPipe/NewPipe/app/src/main/java/org/schabi/newpipe/error/ErrorPanelHelper.kt:9:1: Unused import (no-unused-imports)

> Task :app:runKtlint FAILED

You need to remove the annotation import too.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Isira-Seneviratne Isira-Seneviratne merged commit 0cd1a86 into release-0.25.1 Mar 18, 2023
@TobiGr TobiGr deleted the fix-lint branch March 18, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants