Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicates from playlist feature #9707
Remove duplicates from playlist feature #9707
Changes from 3 commits
eb3363d
135fc08
e26c038
d5b54c8
42fb13f
d8ed2c8
265de55
7617f8c
43f46e2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this run in a separate thread, just like
removeWatchedStreams
? Also, while duplicates are being removed, the loading screen should be shown.You could rename
isRemovingWatched
toisRewritingPlaylist
and use it to prevent concurrent calls to removeDuplicates and removeWatched. Unfortunately this has never been the best solution (since there are other functions that change the playlist that are not guarded by that boolean, and so you might still get concurrent changes to the playlist), but there's no need to rework state handling in this PR (a viewmodel would be needed), so keep it as it was before.