-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seeking no longer pauses the played stream #9496
Seeking no longer pauses the played stream #9496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Why was that even implemented in the first place?
As shown in the screen recording, there should be a white part on seek bar to show how much the video has been played. This is also helpful if the user wants to return to previous point of the video easily. 202887216-312a4ee9-2e4c-4575-a90c-76407e41ff11.mp4 |
@SameenAhnaf Do you believe that implementing this feature is still in scope of this ticket. IMO this is worth opening another issue for. |
Yep. A separate PR for this would be better. |
@SameenAhnaf The white part is the part which has been buffered by the player and like already said, your request is out of the scope of this PR. |
app/src/main/java/org/schabi/newpipe/player/ui/VideoPlayerUi.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
Thank you! |
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
SeekingBefore.mp4
SeekingAfter.mp4
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence