Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeking no longer pauses the played stream #9496

Merged
merged 2 commits into from
Dec 31, 2022

Conversation

Jared234
Copy link
Contributor

@Jared234 Jared234 commented Dec 3, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • the player is not paused while the user is using the seeking feature

Before/After Screenshots/Screen Record

  • Before:
SeekingBefore.mp4
  • After:
SeekingAfter.mp4

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@AudricV AudricV added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) labels Dec 3, 2022
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Why was that even implemented in the first place?

@SameenAhnaf
Copy link
Collaborator

As shown in the screen recording, there should be a white part on seek bar to show how much the video has been played. This is also helpful if the user wants to return to previous point of the video easily.

202887216-312a4ee9-2e4c-4575-a90c-76407e41ff11.mp4

@Jared234
Copy link
Contributor Author

@SameenAhnaf Do you believe that implementing this feature is still in scope of this ticket. IMO this is worth opening another issue for.

@opusforlife2
Copy link
Collaborator

Yep. A separate PR for this would be better.

@AudricV
Copy link
Member

AudricV commented Dec 10, 2022

@SameenAhnaf The white part is the part which has been buffered by the player and like already said, your request is out of the scope of this PR.

@Jared234 Jared234 requested a review from Stypox December 10, 2022 20:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Stypox Stypox merged commit 367ece8 into TeamNewPipe:dev Dec 31, 2022
@Stypox
Copy link
Member

Stypox commented Dec 31, 2022

Thank you!

@AudricV AudricV changed the title Seeking no longer pauses the played video Seeking no longer pauses the played stream Jan 1, 2023
@Stypox Stypox mentioned this pull request Jan 22, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

While seeking, continue playing until you release the seekbar from hold
6 participants