-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Desugaring to 1.1.8 #9481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trending and search results would never load while I was trying to test this out. I could consistently reproduce on API 31, API 33 emulated and API 30 on my phone. API 22 emulated works. The commit before yours has no problems. Search suggestions seem to work and if you look in the network tab of Android Studio's app inspection you will see that requests are actually being made for trending and search results, though for some reason the results never show up.
Interesting 🤔 Let's try 1.1.8 instead. |
fe3782a
to
074a8ff
Compare
Kudos, SonarCloud Quality Gate passed! |
Yeah, it seems to be related to this issue: https://issuetracker.google.com/issues/246512175 I updated the desugar library to 1.2.2 and a similar issue occurred in debug builds (release builds worked fine). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested and with 1.1.8
it works. I hope they'll fix this soon
I believe it's fixed in 2.0, which requires AGP 7.4. |
What is it?
Description of the changes in your PR
Some other things:
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence